[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=408827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408827
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/20 14:57
Start Date: 24/Mar/20 14:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199: [BEAM-9562]
Update Timer encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397213834
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -703,13 +703,21 @@ message StandardCoders {
// Components: Coder for a single element.
ITERABLE = 3 [(beam_urn) = "beam:coder:iterable:v1"];
- // Encodes a timer containing a timestamp and a user specified payload.
- // The encoding is represented as: timestamp payload
- // timestamp - a big endian 8 byte integer representing
millis-since-epoch.
- // The encoded representation is shifted so that the byte
representation of
- // negative values are lexicographically ordered before the byte
representation
- // of positive values. This is typically done by subtracting
-9223372036854775808
- // from the value and encoding it as a signed big endian integer.
Example values:
+ // Encodes a timer containing a user key, a clear bit,
+ // a fire timestamp, a hold timestamp, the windows that the user key is in,
+ // the paneinfo of the user key.
+ // The encoding is represented as:
+ // user key - user defined key, uses the component coder.
+ //
Review comment:
The *dynamic tag* is supposed to be part of the encoding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 408827)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
