[
https://issues.apache.org/jira/browse/BEAM-9044?focusedWorklogId=407749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407749
]
ASF GitHub Bot logged work on BEAM-9044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/20 07:43
Start Date: 23/Mar/20 07:43
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10529:
[BEAM-9044] Protobuf options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r396258150
##########
File path:
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
##########
@@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor
descriptor) {
// Store proto field number in metadata.
FieldType fieldType =
withMetaData(beamFieldTypeFromProtoField(fieldDescriptor),
fieldDescriptor);
Review comment:
> We want to switch this metadata to use options. However you are
translating proto option names directly to field names, which means there's no
guarantee that these other options won't conflict. Maybe prefix all of these
options with something to prevent potential conflict?
What about `beam:option:proto:`, that would make an proto option
`vptech.data.v1.description` into
`beam:option:proto:vptech.data.v1.description`. Making it a URI format
`beam:option` : fixed prefix for options, `proto` : for the extension (will
be avro for avro), `vptech.data.v1` package of the extension and `desciption`
the proto extension field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 407749)
Time Spent: 1h (was: 50m)
> BIP-1: Convert protobuf options to Schema options
> -------------------------------------------------
>
> Key: BEAM-9044
> URL: https://issues.apache.org/jira/browse/BEAM-9044
> Project: Beam
> Issue Type: Sub-task
> Components: extensions-java-protobuf
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Protobuf has a rich metadata system called options. This system is fully
> typed and matches Beams Schema Option system. For now we can only convert the
> following protobuf options:
> * File Options -> _Beam doesn't have this concept_
> * Message Options -> *Beam Schema Options*
> * Field Options -> *Beam Schema Options*
> * Enum Options -> _This can only be done when logical type options are
> available_
> * EnumValue Options -> _This can only be done when logical type options are
> available_
> * Service Options -> _Beam doesn't have this concept_
> * Method Options -> _Beam doesn't have this concept_
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
