[
https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383772
]
ASF GitHub Bot logged work on BEAM-9146:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/20 18:26
Start Date: 07/Feb/20 18:26
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate
GCP Video Intelligence functionality for Python SDK
URL: https://github.com/apache/beam/pull/10764#issuecomment-583541427
> > > Got one question regarding the naming. Is `video_intelligence` a good
name for the module? I'm slightly worried it might cause confusion with the
`google.cloud.videointelligence`.
> >
> >
> > I think it is a good name reflects the underlying service as it is. Not
very different from other gcp io with the similar names to the gcp services.
>
> I started work on https://issues.apache.org/jira/browse/BEAM-9247 to
integrate the vision API in a similar PTransform. However, here the naming gets
more complex. Consider e.g.
>
> ```
> from google.cloud import vision
> from apache_beam.ml.gcp import vision
> ```
>
> One solution for the `vision` transforms is to rename the module
`vision_api` instead. But I think we should be consistent across the different
GCP ML APIs, so perhaps `video_intelligence` will need renaming too.
>
> What's your take? @aaltay
I do not have a good idea. Users could solve this with something like the
following:
```
from google.cloud import vision as gcp_vision_api
from apache_beam.ml.gcp import vision
```
So, maybe it is not a big issue. I agree, it would be good if we can avoid
this state.
Related, in the io folder we have modules named `gcsio`, `bigtableio` etc.
but we also have modules named `bigquery`, `pubsub`. So it is not very
consistent.
We can take the io example and change the names by appending ml, your
example will look like:
```
from google.cloud import vision
from apache_beam.ml.gcp import visionml
from apache_beam.ml.gcp import videointelligenceml (Notice I also dropped _
between the words.)
```
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 383772)
Time Spent: 5h 10m (was: 5h)
> [Python] PTransform that integrates Video Intelligence functionality
> --------------------------------------------------------------------
>
> Key: BEAM-9146
> URL: https://issues.apache.org/jira/browse/BEAM-9146
> Project: Beam
> Issue Type: Sub-task
> Components: io-py-gcp
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> The goal is to create a PTransform that integrates Google Cloud Video
> Intelligence functionality [1].
> The transform should be able to take both video GCS location or video data
> bytes as an input.
> [1] https://cloud.google.com/video-intelligence/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
