[
https://issues.apache.org/jira/browse/BEAM-5192?focusedWorklogId=362579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362579
]
ASF GitHub Bot logged work on BEAM-5192:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 16:10
Start Date: 23/Dec/19 16:10
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #10433: [BEAM-5192]
Add support for Elasticsearch v7 in ElasticsearchIO
URL: https://github.com/apache/beam/pull/10433#discussion_r360933620
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestUtils.java
##########
@@ -165,7 +168,11 @@ static long refreshIndexAndGetCurrentNumDocs(RestClient
restClient, String index
request = new Request("GET", endPoint);
Response response = restClient.performRequest(request);
JsonNode searchResult =
ElasticsearchIO.parseResponse(response.getEntity());
- result = searchResult.path("hits").path("total").asLong();
+ if (backenVersion == 7) {
Review comment:
Yeah, I was thinking about removing these ifs. The aim was at the beginning
was to avoid falling in a not tested case. But anyway, the getBackendVersion
methods protects us from running on a non-tested version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362579)
Time Spent: 0.5h (was: 20m)
> Support Elasticsearch 7.x
> -------------------------
>
> Key: BEAM-5192
> URL: https://issues.apache.org/jira/browse/BEAM-5192
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ES v7 is not out yet. But Elastic team scheduled a breaking change for ES
> 7.0: the removal of the type feature. See
> [https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch]
> This will require a good amont of changes in the IO.
> This ticket is there to track the future work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
