[
https://issues.apache.org/jira/browse/BEAM-8379?focusedWorklogId=344576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344576
]
ASF GitHub Bot logged work on BEAM-8379:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 20:56
Start Date: 15/Nov/19 20:56
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #10062: [BEAM-8379]
Cache Eviction
URL: https://github.com/apache/beam/pull/10062#discussion_r347006276
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -74,10 +83,10 @@ def __init__(self, cache_manager=None):
self._pipeline_results = {}
# Always watch __main__ module.
self.watch('__main__')
- # Do a warning level logging if current python version is below 3.5.3.
- if sys.version_info < (3, 5, 3):
+ # Do a warning level logging if current python version is below 3.6.
+ if sys.version_info < (3, 6):
self._is_py_version_ready = False
- logging.warning('Interactive Beam requires Python 3.5.3+.')
+ logging.warning('Interactive Beam requires Python 3.6+.')
Review comment:
So it sounds like the interactive functionality is available in 3.5.3, but
the particular assert method we use in unit tests is only available on 3.6+,
right? Would it make sense for us to support 3.5.3+, and skip those tests on
<3.6? If we force 3.6+ for support, we'd lose 3.5.3+ users, right?
Perhaps it's fine to do only 3.6+, but just wanting to double click on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344576)
Time Spent: 1h 40m (was: 1.5h)
> Cache Eviction for Interactive Beam
> -----------------------------------
>
> Key: BEAM-8379
> URL: https://issues.apache.org/jira/browse/BEAM-8379
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Evicts cache created by Interactive Beam when an IPython kernel is restarted
> or terminated to release the resource usage that is no longer needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)