[
https://issues.apache.org/jira/browse/BEAM-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929335#comment-16929335
]
Chad Dombrova commented on BEAM-8230:
-------------------------------------
Reposting this from the PR:
There's a misunderstanding here. Pre-commit _does_ run the python 3.x tests,
but it runs many of the tests on python 3.5. This PR introduced tests that can
only run on python 3.6 or higher, and I had to do some extra work to the beam
test framework to make that possible:
https://github.com/apache/beam/pull/9098/commits/0c31f7c8b1c108f7df4cbedfaf9da0ce30092ce0
I appears that same work to properly exclude/include tests at the major + minor
version needs to be done for post-commit tests. I didn't do that simply
because I didn't know it could be a problem. I assumed everything went through
tox.
> Python pre-commits need to include python 3.x tests
> ---------------------------------------------------
>
> Key: BEAM-8230
> URL: https://issues.apache.org/jira/browse/BEAM-8230
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing
> Reporter: Ahmet Altay
> Assignee: Valentyn Tymofieiev
> Priority: Major
>
> Python pre-coomit does not seem to run python 3.x test. This results in post
> commit tests catching simple issues like syntax error.
> Example: https://issues.apache.org/jira/browse/BEAM-8229
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
