[
https://issues.apache.org/jira/browse/BEAM-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922776#comment-16922776
]
Rui Wang edited comment on BEAM-7835 at 9/4/19 7:20 PM:
--------------------------------------------------------
In the short term, adding this rule sounds good to me as it mutually exclusive
with current unbounded-unboudned CoGBK implementation which does not allow non
default trigger.
Once we loose the constraint of unbounded-unbounded CoGBK join to allow non
default trigger, there will be overlapping between the new rule with current
existing rule, it would be an open question how to distinguish these two cases
(maybe through isView property). Because of this, I would suggest you tag the
new rule with experimental flag and explicitly says it's an experimental
feature without guaranteeing backward compatibility. So in case there will be
conflict and we will need some changes.
was (Author: amaliujia):
In the short temr, adding this rule sounds good to me as it mutually exclusive
with current unbounded-unboudned CoGBK implementation which does not allow non
default trigger.
Once we loose the constraint of unbounded-unbounded CoGBK join to allow non
default trigger, there will be overlapping between the new rule with current
existing rule, it would be an open question how to distinguish these two cases
(maybe through isView property). Because of this, I would suggest you tag the
new rule with experimental flag and explicitly says it's an experimental
feature without guaranteeing backward compatibility. So in case there will be
conflict and we will need some changes.
> Support Triggered PCollectionView Join Unbounded windowed PCollection in
> BeamSQL
> --------------------------------------------------------------------------------
>
> Key: BEAM-7835
> URL: https://issues.apache.org/jira/browse/BEAM-7835
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rahul Patwari
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
