[
https://issues.apache.org/jira/browse/BEAM-14513?focusedWorklogId=775217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775217
]
ASF GitHub Bot logged work on BEAM-14513:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/22 19:22
Start Date: 26/May/22 19:22
Worklog Time Spent: 10m
Work Description: lnogueir commented on code in PR #17748:
URL: https://github.com/apache/beam/pull/17748#discussion_r882989924
##########
sdks/go/pkg/beam/io/healthcare/gcpcommon.go:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package healthcare
+
+import (
+ "context"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core"
+ healthcarex "google.golang.org/api/healthcare/v1"
+ "google.golang.org/api/option"
+)
+
+const userAgent = "apache-beam-io-google-cloud-platform-healthcare/" +
core.SdkVersion
+
+func NewGcpHealthcareService() *healthcarex.Service {
Review Comment:
Yes, it was only being exported for developer convenience.
I ended up getting rid of this file completely and simply moving its content
to `common.go` inside `fhirio` package. I had created this file because I was
anticipating the creation of the other healthcare IO connectors (i.e.
[DicomIO](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/DicomIO.java),
[HL7v2IO](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java)),
but I figured it's better to worry about them once we actually decide to
implement them in Go.
Let me know if it looks good this way.
Also, thanks for sharing about the special `internal` directory, I wasn't
aware of it and will keep it in mind for time I face this scenario.
Issue Time Tracking
-------------------
Worklog Id: (was: 775217)
Time Spent: 2h 20m (was: 2h 10m)
> Add Read transform and initial HealthcareClient in Go SDK
> ---------------------------------------------------------
>
> Key: BEAM-14513
> URL: https://issues.apache.org/jira/browse/BEAM-14513
> Project: Beam
> Issue Type: Improvement
> Components: io-go-gcp
> Reporter: Lucas Nogueira
> Assignee: Lucas Nogueira
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This is the first of many tickets to bring
> [FhirIO|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java]
> from Java into the Go SDK.
> It consists of:
> * Adding the
> [Read|https://github.com/apache/beam/blob/3e683606d9a03e7da3d37a83eb16c3a6b96068cd/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java#L455]
> transform in Go SDK
> * Adding a basic implementation of the
> [HttpHealthcareClient|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HttpHealthcareApiClient.java]
> in Go, to be able to authenticate and make the requests needed for the
> transform above.
> Buganizer links:
> - [b/233887489|https://b.corp.google.com/issues/233887489].
> - [b/204355275|https://buganizer.corp.google.com/issues/204355275].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
