[ 
https://issues.apache.org/jira/browse/BEAM-14170?focusedWorklogId=775134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775134
 ]

ASF GitHub Bot logged work on BEAM-14170:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/May/22 16:40
            Start Date: 26/May/22 16:40
    Worklog Time Spent: 10m 
      Work Description: fernando-wizeline commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r882807538


##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
   }
 }
 
+tasks.register("validatesRunnerSickbay", Test) {
+  group = "Verification"
+  description "Validates Direct runner (Sickbay Tests)"
+  systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+          "--runner=DirectRunner",
+  ])
+
+  classpath = configurations.needsRunner
+  testClassesDirs = 
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+
+  filter {
+    for (String test : sickbayTests) {
+      includeTestsMatching test
+    }
+
+    // https://issues.apache.org/jira/browse/BEAM-4191
+    includeTestsMatching 
'org.apache.beam.runners.direct.WatermarkManagerTest.updateWatermarkWithDifferentWindowedValueInstances'

Review Comment:
   Oh, about this one: I'm using the same sickbayTests in both needsRunnerTests 
and validatesRunnerSickbay. For some reason, when I remove the Ignore tag from 
the updateWatermarkWithDifferentWindowedValueInstances method in class 
WatermarkManagerTest and rely solely on the excludeTestsMatching instruction, 
the test gets executed anyway. I'm not really knowledgeable in Gradle, so I'm 
pretty sure there's something I'm missing.
   The quickest workaround I came up with was to just leave the Ignore tag 
there and add the test directly to the validatesRunnerSickbay task.
   Thanks!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 775134)
    Time Spent: 8h  (was: 7h 50m)

> Create a test that runs sickbayed tests
> ---------------------------------------
>
>                 Key: BEAM-14170
>                 URL: https://issues.apache.org/jira/browse/BEAM-14170
>             Project: Beam
>          Issue Type: Test
>          Components: testing
>            Reporter: Kiley Sok
>            Assignee: Andoni Guzman
>            Priority: P2
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> When we sickbay tests we should continue to run them, at least in a new test 
> suite that may hold flaky/sickbayed tests - often we just stop running them 
> forever.
> Create a new test for Python and Java that runs the current sickbayed tests.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to