[ https://issues.apache.org/jira/browse/BEAM-14516?focusedWorklogId=774862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774862 ]
ASF GitHub Bot logged work on BEAM-14516: ----------------------------------------- Author: ASF GitHub Bot Created on: 26/May/22 00:58 Start Date: 26/May/22 00:58 Worklog Time Spent: 10m Work Description: ihji opened a new pull request, #17763: URL: https://github.com/apache/beam/pull/17763 Adding context support for Python callable. We could remove unnecessary workaround like: ``` PythonCallableSource.of( "lambda: __import__('apache_beam.ml.inference.sklearn_inference')" + ".ml.inference.sklearn_inference.SklearnModelLoader(model_uri='/tmp/staged/sklearn_model')") ``` and just use: ``` PythonCallableSource.of( "lambda: SklearnModelLoader(model_uri='/tmp/staged/sklearn_model')") .withContext("from apache_beam.ml.inference.sklearn_inference import SklearnModelLoader") ``` ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. Issue Time Tracking ------------------- Worklog Id: (was: 774862) Remaining Estimate: 0h Time Spent: 10m > Add context support for Python callables > ---------------------------------------- > > Key: BEAM-14516 > URL: https://issues.apache.org/jira/browse/BEAM-14516 > Project: Beam > Issue Type: Improvement > Components: cross-language > Reporter: Heejong Lee > Assignee: Heejong Lee > Priority: P2 > Time Spent: 10m > Remaining Estimate: 0h > > Add context support for Python callables -- This message was sent by Atlassian Jira (v8.20.7#820007)