[ 
https://issues.apache.org/jira/browse/BEAM-14471?focusedWorklogId=774165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774165
 ]

ASF GitHub Bot logged work on BEAM-14471:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/22 18:07
            Start Date: 24/May/22 18:07
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on code in PR #17674:
URL: https://github.com/apache/beam/pull/17674#discussion_r880807313


##########
examples/multi-language/src/main/java/org/apache/beam/examples/multilanguage/PythonDataframeWordCount.java:
##########
@@ -42,19 +41,20 @@
  * An example that counts words in Shakespeare and utilizes a Python external 
transform.
  *
  * <p>This class, {@link PythonDataframeWordCount}, uses Python 
DataframeTransform to count words
- * from the input text file. The Python expansion service provided by 
--expansionService must allow
- * the expansion of apache_beam.dataframe.transforms.DataframeTransform (which 
can be done by
- * passing --fully_qualified_name_glob commandline option when launching the 
expansion service).
+ * from the input text file.
  *
- * <p>Note that, for using Dataflow Runner, you should specify the following 
two additional
- * arguments:
+ * <p>The example command below shows how to run this pipeline on Dataflow 
runner:
  *
  * <pre>{@code
- * --experiments=use_runner_v2
- * 
--sdkHarnessContainerImageOverrides=.*python.*,gcr.io/apache-beam-testing/beam-sdk/beam_python3.8_sdk:latest
+ * ./gradlew :examples:multi-language:pythonDataframeWordCount --args=" \
+ * --runner=DataflowRunner \
+ * --output=gs://{$OUTPUT_BUCKET}/count \
+ * --experiments=use_runner_v2 \

Review Comment:
   Is this required ? For Python if we detect multi-language transforms for 
DataflowRunner we add this experiment automatically (can be updated in a 
separate PR).





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774165)
    Time Spent: 7h 10m  (was: 7h)

> Adding testcases and examples for xlang Python DataframeTransform 
> ------------------------------------------------------------------
>
>                 Key: BEAM-14471
>                 URL: https://issues.apache.org/jira/browse/BEAM-14471
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language, testing
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> Adding testcases and examples for xlang Python DataframeTransform 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to