[
https://issues.apache.org/jira/browse/BEAM-14484?focusedWorklogId=772492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772492
]
ASF GitHub Bot logged work on BEAM-14484:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 15:15
Start Date: 19/May/22 15:15
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17716:
URL: https://github.com/apache/beam/pull/17716#discussion_r877197707
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -348,6 +348,18 @@ func (n *DataSource) makeEncodeElms() func([]*FullValue)
([][]byte, error) {
return encodeElms
}
+func getRTrackerFromRoot(root *FullValue) (sdf.BoundableRTracker, float64,
bool) {
+ tracker, ok :=
root.Elm.(*FullValue).Elm2.(*FullValue).Elm.(sdf.BoundableRTracker)
+ if !ok {
+ return nil, -1.0, false
+ }
+ size, ok := root.Elm2.(float64)
+ if !ok {
Review Comment:
Yes it's the restriction size, since we aren't actually able to access that
information through the tracker even indirectly it gets placed here when the
split result is constructed. It is guaranteed to be a float, so in the same
vein as not getting a BoundableRTracker we have the same "we're not getting
things out that we expect" check. This would only get hit in the event of an
actual breakage deeper in the code that I believe our other testing would hit,
but it's worth checking explicitly. We could justify making the case of getting
a tracker but not a size an error, though.
Issue Time Tracking
-------------------
Worklog Id: (was: 772492)
Time Spent: 1h 50m (was: 1h 40m)
> Improve error message surrounding primary returns in the self-checkpointing
> code
> --------------------------------------------------------------------------------
>
> Key: BEAM-14484
> URL: https://issues.apache.org/jira/browse/BEAM-14484
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P1
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The error message in the Go SDK harness around returned primaries in the
> self-checkpointing code
> ([https://github.com/apache/beam/blob/ea1f292e9cf31fc8c4803b10d811f0d3ee184ae7/sdks/go/pkg/beam/core/runtime/exec/datasource.go#L375)]
> is unclear and should be made more explicit. It should also guide the user
> towards making sure that the restriction behaves properly in the
> self-checkpointing case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
