[ https://issues.apache.org/jira/browse/BEAM-14035?focusedWorklogId=771317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771317 ]
ASF GitHub Bot logged work on BEAM-14035: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/May/22 12:54 Start Date: 17/May/22 12:54 Worklog Time Spent: 10m Work Description: aromanenko-dev opened a new pull request, #17692: URL: https://github.com/apache/beam/pull/17692 Fix checkstyle issue (guava) ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. Issue Time Tracking ------------------- Worklog Id: (was: 771317) Time Spent: 9h 10m (was: 9h) > Convert BigQuery SchemaIO to SchemaTransform > -------------------------------------------- > > Key: BEAM-14035 > URL: https://issues.apache.org/jira/browse/BEAM-14035 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core > Reporter: Lara Schmidt > Assignee: Damon Douglas > Priority: P2 > Fix For: Not applicable > > Time Spent: 9h 10m > Remaining Estimate: 0h > > The output of this task is to refactor > org.apache.beam.sdk.io.gcp.bigquery.BigQuerySchemaIOProvider [1] to implement > SchemaTransform [2] and SchemaTransformProvider interfaces [3]. > Please see https://issues.apache.org/jira/browse/BEAM-14168 for more > information on additional work remaining after this task is complete. > As a result of this task there will be: > 1. one class deletion and four classes created for the PR reflecting whether > we are reading from or writing to BigQuery, via BigQueryIO.Read and > BigQueryIO.Write, respectively. > * delete: > sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java > * create: > sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaTransformReadConfiguration.java > * create: > sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaTransformReadProvider.java > * create: > sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaTransformWriteConfiguration.java > * create: > sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaTransformWriteProvider.java > 2. The testing strategy will leverage the use of the > org.apache.beam.sdk.transforms.display.DisplayData class instead of using the > org.apache.beam.sdk.io.gcp.testing.FakeBigQueryServices. > We will test whether the input of BigQuerySchemaTransformReadConfiguration > yields a BigQueryIO.Read with correct query, tableSpec, useLegacySQL > (defaulted to false), and queryLocation values. > We will test whether the input of BigQuerySchemaTransformWriteConfiguration > yields a BigQueryIO.Write with correct tableReference, createDisposition, and > writeDisposition values. > References: > 1 - > [sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java|https://github.com/apache/beam/blob/fc00b9697a0dfb73a03981f4d6c2c8dd1e316d5e/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java] > 2 - > [SchemaTransform|https://github.com/apache/beam/blob/a47a725863fc8c37a9b8520cebeef83677fe531d/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/SchemaTransform.java] > 3 - > [SchemaTransformProvider|https://github.com/apache/beam/blob/a47a725863fc8c37a9b8520cebeef83677fe531d/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/SchemaTransformProvider.java] -- This message was sent by Atlassian Jira (v8.20.7#820007)