[
https://issues.apache.org/jira/browse/BEAM-14255?focusedWorklogId=770947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770947
]
ASF GitHub Bot logged work on BEAM-14255:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/22 17:08
Start Date: 16/May/22 17:08
Worklog Time Spent: 10m
Work Description: ryanthompson591 commented on code in PR #17671:
URL: https://github.com/apache/beam/pull/17671#discussion_r873967768
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -158,19 +163,18 @@ def __init__(self, model_loader: ModelLoader, clock=None):
self._inference_runner.get_metrics_namespace())
self._clock = clock
if not clock:
- self._clock = _ClockFactory.make_clock()
+ self._clock = time
Review Comment:
I think I can even simplify this more by using time in the parameter
clock = time
Issue Time Tracking
-------------------
Worklog Id: (was: 770947)
Time Spent: 1.5h (was: 1h 20m)
> Drop the clock abastraction and just use time.time for time measurements
> ------------------------------------------------------------------------
>
> Key: BEAM-14255
> URL: https://issues.apache.org/jira/browse/BEAM-14255
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Right now the TFX-BSL Runinference library uses an abstract clock class to
> get microsecond precision, but time.time should give an adequate precision.
>
> Investigate removing the clock abstraction and just using time.time.
>
> Alternatively, comment why the abstraction is useful.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
