[ 
https://issues.apache.org/jira/browse/BEAM-14430?focusedWorklogId=769926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769926
 ]

ASF GitHub Bot logged work on BEAM-14430:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/May/22 22:10
            Start Date: 12/May/22 22:10
    Worklog Time Spent: 10m 
      Work Description: ihji commented on code in PR #17608:
URL: https://github.com/apache/beam/pull/17608#discussion_r871846628


##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -162,6 +167,26 @@ public PythonExternalTransform<InputT, OutputT> 
withKwargs(Row kwargs) {
     return this;
   }
 
+  /**
+   * Specifies the field type of arguments.
+   *
+   * <p>Type hints are especially useful for logical types since type 
inference does not work well
+   * for logical types.
+   *
+   * @param argType A class object for the argument type.
+   * @param fieldType A schema field type for the argument.
+   * @return updated wrapper for the cross-language transform.
+   */
+  public PythonExternalTransform<InputT, OutputT> withTypeHint(

Review Comment:
   Per type makes more sense to me. Do you have any specific per arg use-case 
in mind?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 769926)
    Time Spent: 2h 50m  (was: 2h 40m)

> Adding a logical type support for Python callables to Row schema
> ----------------------------------------------------------------
>
>                 Key: BEAM-14430
>                 URL: https://issues.apache.org/jira/browse/BEAM-14430
>             Project: Beam
>          Issue Type: New Feature
>          Components: cross-language
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Adding a logical type support for Python callables to Row schema



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to