[ 
https://issues.apache.org/jira/browse/BEAM-14000?focusedWorklogId=758167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758167
 ]

ASF GitHub Bot logged work on BEAM-14000:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Apr/22 23:35
            Start Date: 18/Apr/22 23:35
    Worklog Time Spent: 10m 
      Work Description: egalpin commented on PR #17297:
URL: https://github.com/apache/beam/pull/17297#issuecomment-1101856232

   @nishantjain91 Overall this change looks good at the moment, thanks! The 
blocker now is that we need to determine the best structure for test suites. 
   
   I think the best approach for now would be to include a test in each of the 
suites for each of the supported ES versions. The ES tests could do with 
restructuring overall, but I don’t think your PR should be blocked by that 
additional effort. 
   
   So please add a case for this test in the suite of each supported version 
and then I feel we can merge. You may need to rebase on master as support for 
version 8.x of ES was recently added (which simultaneously dropped support for 
version 2.x of ES). 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 758167)
    Time Spent: 1h 40m  (was: 1.5h)

> Elastic search IO doesnot work when both username/password and keystore are 
> used
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-14000
>                 URL: https://issues.apache.org/jira/browse/BEAM-14000
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: nishant jain
>            Priority: P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> When using both username/password and ssl keystore, ElasticSearchIO doesnot 
> Create correct restclient.
>  
> Firstly, it sets HttpClientConfigCallback using httpAsyncClientBuilder if 
> username and passowrd is used. Afterwards, it will replace 
> HttpClientConfigCallback to httpClientBuilder is ssl store is used, hence 
> losing the credentials provider



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to