[ 
https://issues.apache.org/jira/browse/BEAM-14287?focusedWorklogId=755448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755448
 ]

ASF GitHub Bot logged work on BEAM-14287:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 21:32
            Start Date: 11/Apr/22 21:32
    Worklog Time Spent: 10m 
      Work Description: jrmccluskey commented on code in PR #17337:
URL: https://github.com/apache/beam/pull/17337#discussion_r847752479


##########
sdks/go/pkg/beam/core/graph/coder/row_test.go:
##########
@@ -228,7 +228,6 @@ type UserType4 struct {
 type unexportedUserType struct {
        A int
        B string
-       c int32

Review Comment:
   Yeah the struct gets embedded but the unit test doesn't check the field at 
all. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755448)
    Time Spent: 1.5h  (was: 1h 20m)

> Address Staticcheck warnings in the graph/coder package
> -------------------------------------------------------
>
>                 Key: BEAM-14287
>                 URL: https://issues.apache.org/jira/browse/BEAM-14287
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Jack McCluskey
>            Assignee: Jack McCluskey
>            Priority: P2
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Simplify logic and remove unused functions/fields in the graph/coder package. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to