[
https://issues.apache.org/jira/browse/BEAM-14244?focusedWorklogId=753383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753383
]
ASF GitHub Bot logged work on BEAM-14244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/22 13:23
Start Date: 06/Apr/22 13:23
Worklog Time Spent: 10m
Work Description: steveniemitz commented on code in PR #17262:
URL: https://github.com/apache/beam/pull/17262#discussion_r843945145
##########
runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperatorTest.java:
##########
@@ -305,7 +305,10 @@ public void processElement(
eventTimerWithOutputTimestamp
.withOutputTimestamp(timerOutputTimestamp)
.set(timerTimestamp);
-
processingTimer.offset(Duration.millis(timerTimestamp.getMillis())).setRelative();
+ processingTimer
Review Comment:
to close the loop here, I updated the Flink DoFnOperator to preserve the
existing behavior. If it wasn't changed, it could potentially produce late
data since there's no watermark hold on the output timestamp. In a follow up
review we can fix it to set a watermark hold on the output timestamp of
processing time timers (essentially unifying them with event time timers).
Issue Time Tracking
-------------------
Worklog Id: (was: 753383)
Time Spent: 2h (was: 1h 50m)
> Processing time timers should use outputTimestamp rather than input watermark
> for their timestamp
> -------------------------------------------------------------------------------------------------
>
> Key: BEAM-14244
> URL: https://issues.apache.org/jira/browse/BEAM-14244
> Project: Beam
> Issue Type: Bug
> Components: runner-core, sdk-java-core
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P1
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently processing time timers ignore the outputTimestamp and instead use
> the input watermark at the time they fire. This is wrong because the input
> watermark can have advanced arbitrarily far past the actual output timestamp
> when it fires.
> The correct behavior should be to instead use the outputTimestamp the timer
> was configured to fire with.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
