[
https://issues.apache.org/jira/browse/BEAM-13939?focusedWorklogId=751334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751334
]
ASF GitHub Bot logged work on BEAM-13939:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/22 01:33
Start Date: 01/Apr/22 01:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1085300892
Also, for auto-generated files, I think adding them to RAT is better than
modifying these files--they're (clearly marked) machine output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 751334)
Time Spent: 23h 20m (was: 23h 10m)
> Go SDK: Protobuf namespace conflict
> -----------------------------------
>
> Key: BEAM-13939
> URL: https://issues.apache.org/jira/browse/BEAM-13939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go
> Affects Versions: 2.36.0
> Reporter: Milan Patel
> Priority: P2
> Attachments: demobug.zip
>
> Time Spent: 23h 20m
> Remaining Estimate: 0h
>
> The Go SDK generated grpc protobufs are not namespaced with enough
> granularity. If a user has another external dependency with the same protobuf
> file registered with the proto runtime, their compiled binary will panic at
> runtime pointing the user to this [doc
> page|https://developers.google.com/protocol-buffers/docs/reference/go/faq#fix-namespace-conflict].
>
> In the interim, following the instructions to add either ldflags to the
> compiler or an environment var to the binary works, but this is an unideal
> solution since only one of the duplicate proto specifications will be
> accessible from a [global
> registry|https://pkg.go.dev/google.golang.org/protobuf@v1.27.1/reflect/protoregistry].
>
> Ask: Regenerate the go protos such that descriptors like
> [these|https://github.com/apache/beam/blob/84353a7c973d3acaaa56d81c265dce7193a56be5/sdks/go/pkg/beam/model/pipeline_v1/metrics.pb.go#L797-L811]
> are outputted with filenames that are more granular, such as a filename that
> includes the directory structure of the repository.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
