[
https://issues.apache.org/jira/browse/BEAM-14098?focusedWorklogId=744533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744533
]
ASF GitHub Bot logged work on BEAM-14098:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/22 00:51
Start Date: 19/Mar/22 00:51
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #17088:
URL: https://github.com/apache/beam/pull/17088#issuecomment-1067220208
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17088](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(95b35f6) into
[master](https://codecov.io/gh/apache/beam/commit/2cec50b0f1b87388fb408b6af3e09c22ca4a627c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2cec50b) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17088 +/- ##
==========================================
+ Coverage 73.95% 73.96% +0.01%
==========================================
Files 667 671 +4
Lines 88072 88182 +110
==========================================
+ Hits 65135 65226 +91
- Misses 21826 21844 +18
- Partials 1111 1112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.45% <ø> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/util/reflectx/tags.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvdGFncy5nbw==)
| `0.00% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/util/ioutilx/write.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvaW91dGlseC93cml0ZS5nbw==)
| `100.00% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/options/jobopts/stringSlice.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2pvYm9wdHMvc3RyaW5nU2xpY2UuZ28=)
| `71.42% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/util/ioutilx/read.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvaW91dGlseC9yZWFkLmdv)
| `74.35% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/options/jobopts/options.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2pvYm9wdHMvb3B0aW9ucy5nbw==)
| `87.27% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/runtime/pipelinex/replace.go](https://codecov.io/gh/apache/beam/pull/17088/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvcGlwZWxpbmV4L3JlcGxhY2UuZ28=)
| `66.66% <0.00%> (+0.71%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2cec50b...95b35f6](https://codecov.io/gh/apache/beam/pull/17088?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744533)
Time Spent: 2h 20m (was: 2h 10m)
> Abstract the details of JDBC IO like driver information from user in Go SDK
> ---------------------------------------------------------------------------
>
> Key: BEAM-14098
> URL: https://issues.apache.org/jira/browse/BEAM-14098
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently, the users have to specify driver name for the database they are
> intending to connect with jdbc. This may not be absolutely required to some
> users who prefer to go with default driver for that database.
> For ex: To do write operation with jdbc io, users have to write
> {code:java}
> jdbcio.Write(s, tableName, driverClassName, jdbcurl, username, password,
> jdbcio.ExpansionAddrWrite("localhost:9000")){code}
> We want to have transforms like
> {code:java}
> jdbcio.WriteFromPostgres(s, tableName, jdbcurl, username, password,
> jdbcio.ExpansionAddrWrite("localhost:9000")){code}
> We will keep the original API as it though to avoid any breakage and to
> support other databases unless we add specific APIs for them or for the user.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
