[ 
https://issues.apache.org/jira/browse/BEAM-14051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506386#comment-17506386
 ] 

Brian Hulette commented on BEAM-14051:
--------------------------------------

[~dmitryor] should we keep this open to track further improvements?

> There should be single source of truth for the project version
> --------------------------------------------------------------
>
>                 Key: BEAM-14051
>                 URL: https://issues.apache.org/jira/browse/BEAM-14051
>             Project: Beam
>          Issue Type: Wish
>          Components: build-system
>            Reporter: Dmitry Orlovsky
>            Priority: P3
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Now the Beam version is defined in two places:
>  * via the 'version' parameter [in 
> gradle.properties|https://github.com/apache/beam/blob/master/gradle.properties#L27],
>  * programmatically in the `apply` function [in 
> BeamModulePlugin|[https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L384-L387].]
> The latter effectively overrides the former. For someone not very familiar 
> with the Beam build system this may result in a hard to understand and debug 
> behavior: unexpected version gets build and/or pushed to local Maven 
> repository, and changing version in `gradle.properties` does not have any 
> effect.
> Adding a comment with a reference to `BeamModulePlugin` to 
> `gradle.properties` can be a good start, and in the long run it would be 
> great to have single source of truth for the project version.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to