[
https://issues.apache.org/jira/browse/BEAM-13813?focusedWorklogId=720562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720562
]
ASF GitHub Bot logged work on BEAM-13813:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 00:43
Start Date: 04/Feb/22 00:43
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #16710:
URL: https://github.com/apache/beam/pull/16710#discussion_r799082834
##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -150,6 +158,12 @@ func extractStagingToPath(artifact
*pipepb.ArtifactInformation) (string, error)
return "", err
}
stagedName = generateId() + "-" + filepath.Base(ty.Path)
+ } else if artifact.TypeUrn == URNUrlArtifact {
Review comment:
If the staging_to role is defined, we follow the naming definition from
the role payload. However we just generate the staging name when the file name
is not important. For example, the name is not important for Python pip
requirement file so we use pip_requirement role instead of staging_to role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 720562)
Time Spent: 3h (was: 2h 50m)
> Add support for URL artifact to extractStagingToPath
> ----------------------------------------------------
>
> Key: BEAM-13813
> URL: https://issues.apache.org/jira/browse/BEAM-13813
> Project: Beam
> Issue Type: New Feature
> Components: cross-language
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add support for URL artifact to extractStagingToPath
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
