[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=719726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719726
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/22 21:58
Start Date: 02/Feb/22 21:58
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r798046896
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/registry.go
##########
@@ -220,7 +220,11 @@ func (r *registry) getHandlerFunc(urn, expansionAddr
string) (HandlerFunc, strin
// By the time this is called, we want *some* kind of HandlerFunc at
all,
// So first we check for the hard override.
ns, config := parseAddr(expansionAddr)
- if ns == hardOverrideNamespace {
+ if ns == autoNamespace {
+ // Leave expansionAddr unmodified so the autoNamespace keyword
sticks.
+ // We strip it manually in the HandlerFunc.
+ return QueryAutomatedExpansionService, expansionAddr
Review comment:
I bumped the check to after the URN override changes the namespace and
address variables so an URN override can point to an auto set-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 719726)
Time Spent: 23h (was: 22h 50m)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 23h
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
