[
https://issues.apache.org/jira/browse/BEAM-13399?focusedWorklogId=719632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719632
]
ASF GitHub Bot logged work on BEAM-13399:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/22 19:59
Start Date: 02/Feb/22 19:59
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16671:
URL: https://github.com/apache/beam/pull/16671#discussion_r797966725
##########
File path: sdks/go/pkg/beam/transforms/sql/sql.go
##########
@@ -114,6 +116,9 @@ func Transform(s beam.Scope, query string, opts ...Option)
beam.PCollection {
if o.expansionAddr != "" {
expansionAddr = xlangx.Require(o.expansionAddr)
}
+ if expansionAddr == sqlx.DefaultExpansionAddr {
+ expansionAddr =
xlangx.UseAutomatedExpansionService(serviceGradleTarget)
Review comment:
We can do this but if we move the auto handling to the `sqlx` package
we'll have to drop some documenting comment in to explain that the default is
an automated service being spun up. Having things divorced between the two
packages isn't my favorite set-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 719632)
Time Spent: 20h 50m (was: 20h 40m)
> [Go SDK] Add automated expansion service start up feature
> ---------------------------------------------------------
>
> Key: BEAM-13399
> URL: https://issues.apache.org/jira/browse/BEAM-13399
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 20h 50m
> Remaining Estimate: 0h
>
> Add Go SDK support for automated expansion service start-up if one is not
> provided, following the example of the Python implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
