[
https://issues.apache.org/jira/browse/BEAM-12435?focusedWorklogId=715815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715815
]
ASF GitHub Bot logged work on BEAM-12435:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 16:35
Start Date: 26/Jan/22 16:35
Worklog Time Spent: 10m
Work Description: mosche edited a comment on pull request #16607:
URL: https://github.com/apache/beam/pull/16607#issuecomment-1022373263
Yes @aromanenko-dev, there was no test coverage :/ Added the missing tests
https://github.com/apache/beam/pull/16623
Though, wondering why S3FileSystemIT didn't surface the issue since the
empty SSECustomerKey is the default created in S3Options and fails
deserialization. Will have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715815)
Time Spent: 5.5h (was: 5h 20m)
> Generalize S3FileSystem
> -----------------------
>
> Key: BEAM-12435
> URL: https://issues.apache.org/jira/browse/BEAM-12435
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Matt Rudary
> Assignee: Matt Rudary
> Priority: P2
> Labels: aws, aws-s3
> Fix For: 2.32.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> I'm working with multiple storage systems that speak the S3 api. I would like
> to support FileIO operations for these storage systems, but S3FileSystem
> hardcodes the s3 scheme (the various systems use different URI schemes) and
> it is in any case impossible to instantiate more than one in the current
> design.
> I'd like to refactor the code in org.apache.beam.sdk.io.aws.s3 (and maybe
> ...aws.options) somewhat to enable this use-case. I haven't worked out the
> details yet, but it will take some thought to make this work in a non-hacky
> way.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
