[
https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=712315&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712315
]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 19:40
Start Date: 20/Jan/22 19:40
Worklog Time Spent: 10m
Work Description: roger-mike commented on a change in pull request #16522:
URL: https://github.com/apache/beam/pull/16522#discussion_r789094772
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3863,7 +3863,6 @@ def idxmin(self, **kwargs):
def idxmax(self, **kwargs):
return self._idxmaxmin_helper('idxmax', **kwargs)
-
Review comment:
Unrelated change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 712315)
Time Spent: 4.5h (was: 4h 20m)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally:
> https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g.
> [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html]
> because of BEAM-6158), but most of them are verifying good conventions that
> we should try to stick to. Let's enable as many of the checks as possible,
> such that the only disabled checks are really impractical for Beam, or are
> incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
