[ 
https://issues.apache.org/jira/browse/BEAM-13699?focusedWorklogId=712304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712304
 ]

ASF GitHub Bot logged work on BEAM-13699:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jan/22 19:15
            Start Date: 20/Jan/22 19:15
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #16573:
URL: https://github.com/apache/beam/pull/16573#issuecomment-1017839003


   I think a small change to also having a io buffer to the more complicated 
encodings, will also improve hashing for custom coders and the like. I'll try 
it, but send a different PR for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 712304)
    Time Spent: 1h 40m  (was: 1.5h)

> [Go SDK] Change Combiner Lifting hash to maphash.
> -------------------------------------------------
>
>                 Key: BEAM-13699
>                 URL: https://issues.apache.org/jira/browse/BEAM-13699
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> https://pkg.go.dev/hash/maphash is actually intended for use as a hashtable 
> hash, and leverages the go runtime's efficient map hasher. This will 
> hopefully lead to a mild speedup, and with the additional random seeds 
> (consistent for the life of a hasher) will reduce the odds of collisions vs 
> the current deterministic hasher.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to