[
https://issues.apache.org/jira/browse/BEAM-10206?focusedWorklogId=712193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712193
]
ASF GitHub Bot logged work on BEAM-10206:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 16:48
Start Date: 20/Jan/22 16:48
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on a change in pull request
#16575:
URL: https://github.com/apache/beam/pull/16575#discussion_r788955658
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go
##########
@@ -132,10 +132,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) {
}
go func() {
if err := p.Execute(context.Background(), "1", DataContext{});
err != nil {
- b.Fatalf("execute failed: %v", err)
+ b.Errorf("execute failed: %v", err)
Review comment:
Well looks like the issue with the blocking was because I was checking
before close(process) was called. I like the channel method better because it's
a little more clear how the error is handled compared to the error + return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 712193)
Time Spent: 3h 40m (was: 3.5h)
> [Go SDK] Jenkins static checks
> --------------------------------
>
> Key: BEAM-10206
> URL: https://issues.apache.org/jira/browse/BEAM-10206
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Labels: starter
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> We should probably hook up static checks
> [https://staticcheck.io|https://staticcheck.io/] to avoid style and lint
> regressions, and to run them locally and fix most of them.
> Additional configuration we could probably integrate should take the proto
> import conventions we've established (see PR 11927) so that we use consistent
> short names.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
