[ 
https://issues.apache.org/jira/browse/BEAM-13701?focusedWorklogId=712046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712046
 ]

ASF GitHub Bot logged work on BEAM-13701:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jan/22 13:14
            Start Date: 20/Jan/22 13:14
    Worklog Time Spent: 10m 
      Work Description: daria-malkova commented on a change in pull request 
#16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r788750936



##########
File path: 
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##########
@@ -143,3 +152,41 @@ func updateJavaLogConfigFile(paths fs_tool.LifeCyclePaths) 
error {
        }
        return nil
 }
+
+func prepareSbtFiles(lc *fs_tool.LifeCycle, pipelineFolder string, workingDir 
string) (*fs_tool.LifeCycle, error) {
+       cmd := exec.Command("sh", filepath.Join(workingDir, 
"new_scio_project.sh"))
+       cmd.Dir = pipelineFolder
+       _, err := cmd.Output()
+       if err != nil {
+               return nil, err
+       }
+
+       sourceFileFolder := filepath.Join(pipelineFolder, projectPath)
+       fileName := lc.Paths.SourceFileName
+       absFileFolderPath, _ := filepath.Abs(sourceFileFolder)
+       absFilePath, _ := filepath.Abs(filepath.Join(absFileFolderPath, 
fileName))
+       absLogFilePath, _ := filepath.Abs(filepath.Join(absFileFolderPath, 
logFileName))
+       projectFolder, _ := filepath.Abs(filepath.Join(pipelineFolder, 
scioProjectName))
+       executableName := lc.Paths.ExecutableName
+
+       _, err = exec.Command("rm", filepath.Join(absFileFolderPath, 
"WordCount.scala")).Output()

Review comment:
       There is no need anywhere else for this constant, but I can move it to 
constant variab
   e

##########
File path: 
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##########
@@ -143,3 +152,41 @@ func updateJavaLogConfigFile(paths fs_tool.LifeCyclePaths) 
error {
        }
        return nil
 }
+
+func prepareSbtFiles(lc *fs_tool.LifeCycle, pipelineFolder string, workingDir 
string) (*fs_tool.LifeCycle, error) {
+       cmd := exec.Command("sh", filepath.Join(workingDir, 
"new_scio_project.sh"))
+       cmd.Dir = pipelineFolder
+       _, err := cmd.Output()
+       if err != nil {
+               return nil, err
+       }
+
+       sourceFileFolder := filepath.Join(pipelineFolder, projectPath)
+       fileName := lc.Paths.SourceFileName
+       absFileFolderPath, _ := filepath.Abs(sourceFileFolder)
+       absFilePath, _ := filepath.Abs(filepath.Join(absFileFolderPath, 
fileName))
+       absLogFilePath, _ := filepath.Abs(filepath.Join(absFileFolderPath, 
logFileName))
+       projectFolder, _ := filepath.Abs(filepath.Join(pipelineFolder, 
scioProjectName))
+       executableName := lc.Paths.ExecutableName
+
+       _, err = exec.Command("rm", filepath.Join(absFileFolderPath, 
"WordCount.scala")).Output()

Review comment:
       There is no need anywhere else for this constant, but I can move it to 
constant variable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 712046)
    Time Spent: 1h  (was: 50m)

> Support example execution of SCIO code
> --------------------------------------
>
>                 Key: BEAM-13701
>                 URL: https://issues.apache.org/jira/browse/BEAM-13701
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-playground
>            Reporter: Daria Malkova
>            Assignee: Daria Malkova
>            Priority: P3
>              Labels: beam-playground-backend, beam-playground-sprint-7
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to