[ 
https://issues.apache.org/jira/browse/BEAM-13633?focusedWorklogId=711354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711354
 ]

ASF GitHub Bot logged work on BEAM-13633:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jan/22 12:19
            Start Date: 19/Jan/22 12:19
    Worklog Time Spent: 10m 
      Work Description: pavel-avilov commented on a change in pull request 
#16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r787688661



##########
File path: playground/backend/internal/environment/environment_service.go
##########
@@ -240,6 +246,16 @@ func getConfigFromJson(configPath string) 
(*ExecutorConfig, error) {
        return &executorConfig, err
 }
 
+// getDefaultExamplesPathFromJson reads a json file and returns default 
example path
+func getDefaultExamplesPathFromJson(configPath string) (string, error) {
+       file, err := ioutil.ReadFile(configPath)
+       if err != nil {
+               return "", err
+       }
+       defaultExamplePath := gjson.Get(string(file), 
defaultExampleKey).String()
+       return defaultExamplePath, nil
+}

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 711354)
    Time Spent: 3h 20m  (was: 3h 10m)

> Implement method to get a default example for each SDKs
> -------------------------------------------------------
>
>                 Key: BEAM-13633
>                 URL: https://issues.apache.org/jira/browse/BEAM-13633
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-playground
>            Reporter: Pavel Avilov
>            Assignee: Pavel Avilov
>            Priority: P2
>              Labels: beam-playground-backend, beam-playground-sprint-7
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Need to implement a method that will return a default example for each SDKs. 
> Store the description of default examples in the config.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to