[ https://issues.apache.org/jira/browse/BEAM-13137?focusedWorklogId=709000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709000 ]
ASF GitHub Bot logged work on BEAM-13137: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Jan/22 12:06 Start Date: 14/Jan/22 12:06 Worklog Time Spent: 10m Work Description: echauchot commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013063017 > All previously skipped tests passed: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20510/testReport/org.apache.beam.sdk.io.elasticsearch/ElasticsearchIOTest/ > > Of course, a singular test run does not constitute a sample set, but failures used to be so prevalent that most PRs had to have unit tests retried at least once; these tests passing is a strong first indicator. Please run a hundred test with your IDE repeat fonction so that we can have proper stats. Then, the good thing to do is to merge the fix and audit for 2 weeks the flakiness frequency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 709000) Time Spent: 50m (was: 40m) > make ElasticsearchIO$BoundedElasticsearchSource#getEstimatedSizeBytes > deterministic > ----------------------------------------------------------------------------------- > > Key: BEAM-13137 > URL: https://issues.apache.org/jira/browse/BEAM-13137 > Project: Beam > Issue Type: Improvement > Components: io-java-elasticsearch > Reporter: Etienne Chauchot > Assignee: Evan Galpin > Priority: P2 > Time Spent: 50m > Remaining Estimate: 0h > > Index size estimation is statistical in ES and varies. But it is the base for > splitting so it needs to be more deterministic because that causes flakiness > in the UTests in _testSplit_ and _testSizes_ and maybe entails sub-optimal > splitting in production in some cases. -- This message was sent by Atlassian Jira (v8.20.1#820001)