[ 
https://issues.apache.org/jira/browse/BEAM-13503?focusedWorklogId=708419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708419
 ]

ASF GitHub Bot logged work on BEAM-13503:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jan/22 15:34
            Start Date: 13/Jan/22 15:34
    Worklog Time Spent: 10m 
      Work Description: egalpin commented on pull request #16309:
URL: https://github.com/apache/beam/pull/16309#issuecomment-1012248745


   Thanks @khersey for adding the common method for the tests! I admit that the 
testing setup for Elasticsearch could be improved, but this new method you've 
add will need to be invoked in each of the unit test files (one for each 
support ES version) named `ElasticsearchIOTest.java` found here:
   
   https://github.com/apache/beam/tree/master/sdks/java/io/elasticsearch-tests
   
   Ex. elasticsearch 7 test suite:
   
https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch-tests/elasticsearch-tests-7/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java
   
   This is where your new test will be invoked from; presently the method you 
added is not invoked by the test runner.  Please ping back here if you continue 
to be blocked by the jcenter issue you posted previously.  If you're unblocked 
on that, you can invoke test suites locally by using gradle:
   
   ```./gradlew --info 
:sdks:java:io:elasticsearch-tests:elasticsearch-tests-7:test```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 708419)
    Time Spent: 2h 40m  (was: 2.5h)

> BulkIO public constructor: Missing required property: throwWriteErrors
> ----------------------------------------------------------------------
>
>                 Key: BEAM-13503
>                 URL: https://issues.apache.org/jira/browse/BEAM-13503
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-elasticsearch
>    Affects Versions: 2.35.0
>            Reporter: Kyle Hersey
>            Assignee: Kyle Hersey
>            Priority: P1
>              Labels: elasticsearch
>   Original Estimate: 1h
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Using 2.35.0 latest RC to debug an issue while writing to Elasticsearch, but 
> ran into a build issue:
> {code:java}
> java.lang.IllegalStateException: Missing required properties: 
> throwWriteErrors {code}
> Tracing this error through throwWriteErrors is not Nullable, and is therefor 
> required in the AutoValue_ElasticsearchIO_BuilkIO$Builder
> Should be an easy fix, just need to set a default value for it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to