[
https://issues.apache.org/jira/browse/BEAM-13633?focusedWorklogId=707417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707417
]
ASF GitHub Bot logged work on BEAM-13633:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/22 11:43
Start Date: 12/Jan/22 11:43
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r782993729
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -173,6 +175,28 @@ func (cd *CloudStorage) GetPrecompiledObjects(ctx
context.Context, targetSdk pb.
return &precompiledObjects, nil
}
+// GetDefaultPrecompileObject returns the default precompiled object for the
sdk
+func (cd *CloudStorage) GetDefaultPrecompileObject(ctx context.Context,
targetSdk pb.Sdk, workingDir string) (*ObjectInfo, error) {
+ defaultExampleToSdk, err := getDefaultExamplesFromJson(workingDir)
Review comment:
Add error handling.
##########
File path: playground/backend/configs/DEFAULT_EXAMPLES.json
##########
@@ -0,0 +1,5 @@
+{
Review comment:
I am not sure that this file should be in `configs` folder. @KhaninArtur
@ilya-kozyrev what do you think?
##########
File path: playground/frontend/lib/api/v1/api.pbgrpc.dart
##########
@@ -17,13 +17,18 @@
*/
///
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields
+
Review comment:
Remove this one.
##########
File path: playground/frontend/lib/api/v1/api.pbjson.dart
##########
@@ -17,8 +17,14 @@
*/
///
-import 'dart:convert' as $convert;
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields,deprecated_member_use_from_same_package
+
Review comment:
Remove this one.
##########
File path: playground/backend/configs/DEFAULT_EXAMPLES.json
##########
@@ -0,0 +1,5 @@
+{
+ "SDK_JAVA": "SDK_JAVA/MinimalWordCount",
+ "SDK_GO": "SDK_GO/MinimalWordCount",
+ "SDK_PYTHON": "SDK_PYTHON/WordCountWithMetrics"
+}
Review comment:
Add an empty string.
##########
File path: playground/frontend/lib/api/v1/api.pb.dart
##########
@@ -17,6 +17,12 @@
*/
///
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields
+
Review comment:
Remove this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 707417)
Time Spent: 0.5h (was: 20m)
> Implement method to get a default example for each SDKs
> -------------------------------------------------------
>
> Key: BEAM-13633
> URL: https://issues.apache.org/jira/browse/BEAM-13633
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Pavel Avilov
> Assignee: Pavel Avilov
> Priority: P2
> Labels: beam-playground-backend, beam-playground-sprint-7
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Need to implement a method that will return a default example for each SDKs.
> Store the description of default examples in the config.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
