[ 
https://issues.apache.org/jira/browse/BEAM-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Knowles updated BEAM-3640:
----------------------------------

This Jira ticket has a pull request attached to it, but is still open. Did the 
pull request resolve the issue? If so, could you please mark it resolved? This 
will help the project have a clear view of its open issues.

> Checkstyle enforcement of blank lines
> -------------------------------------
>
>                 Key: BEAM-3640
>                 URL: https://issues.apache.org/jira/browse/BEAM-3640
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Daniel Kulp
>            Priority: P3
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Checkstyle has a rule (EmptyLineSeparator) we currently don't use to enforce 
> the use of blank lines in various places.   In order to reduce the noise in 
> reviews of PR's, I like to start using it.
> This will likely be accomplished via a series of PR's.   Just adding the 
> default EmptyLineSeparator to the checkstyle rules results in a THOUSANDS of 
> violations which would be hard to review.   I will likely enable it for one 
> token type at a time, fix the violations on that particular token type, 
> submit, add then next token type, etc... That should  (hopefully) keep each 
> PR down to something that can reasonably be reviewed. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to