[
https://issues.apache.org/jira/browse/BEAM-11808?focusedWorklogId=701652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-701652
]
ASF GitHub Bot logged work on BEAM-11808:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/21 19:11
Start Date: 28/Dec/21 19:11
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16200:
URL: https://github.com/apache/beam/pull/16200#discussion_r776039814
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -180,6 +176,43 @@
null,
new CastFunctionImpl());
+ public static SqlOperator createStringAggOperator(
+ ResolvedNodes.ResolvedFunctionCallBase aggregateFunctionCall) {
+ List<ResolvedNodes.ResolvedExpr> args =
aggregateFunctionCall.getArgumentList();
+ String inputType = args.get(0).getType().typeName();
+ Value delimiter = null;
+ if (args.size() == 2) {
+ delimiter = ((ResolvedNodes.ResolvedLiteral) args.get(1)).getValue();
+ }
+ switch (inputType) {
+ case "BYTES":
+ if (delimiter != null) {
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARBINARY),
+ new UdafImpl<>(new
StringAgg.StringAggByte(delimiter.getBytesValue().toByteArray())));
+ }
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARBINARY),
+ new UdafImpl<>(new StringAgg.StringAggByte()));
+ case "STRING":
+ if (delimiter != null) {
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARCHAR),
+ new UdafImpl<>(new
StringAgg.StringAggString(delimiter.getStringValue())));
+ }
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARCHAR),
+ new UdafImpl<>(new StringAgg.StringAggString()));
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 701652)
Time Spent: 2h 20m (was: 2h 10m)
> ZetaSQL layer doesn't support aggregate functions with two arguments
> ---------------------------------------------------------------------
>
> Key: BEAM-11808
> URL: https://issues.apache.org/jira/browse/BEAM-11808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Sonam Ramchand
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Blocked by: parsed ZetaSQL to a Calcite logical expression doesn't currently
> support aggregate functions with multiple columns.
> [https://github.com/apache/beam/blob/3bb232fb098700de408f574585dfe74bbaff7230/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L147]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
