[
https://issues.apache.org/jira/browse/BEAM-13471?focusedWorklogId=701504&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-701504
]
ASF GitHub Bot logged work on BEAM-13471:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Dec/21 12:28
Start Date: 28/Dec/21 12:28
Worklog Time Spent: 10m
Work Description: KhaninArtur commented on a change in pull request
#16325:
URL: https://github.com/apache/beam/pull/16325#discussion_r775869626
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/TfIdfTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.examples.complete;
+// beam-playground:
+// name: TfIdfTest
+// description: Unit-test for the TfIdf example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Side Input
Review comment:
```suggestion
// - Side Input
// - Flatten
```
##########
File path: sdks/go/pkg/beam/partition_test.go
##########
@@ -15,6 +15,14 @@
package beam_test
+// beam-playground:
+// name: PartitionTest
+// description: Unit-test for the Partition example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Testing
Review comment:
```suggestion
// - Core Transforms
```
##########
File path: sdks/python/apache_beam/examples/wordcount_minimal_test.py
##########
@@ -19,6 +19,14 @@
# pytype: skip-file
+# beam-playground:
+# name: WordCountMinimalTest
+# description: Unit-test for the minimal WordCount example.
+# multifile: false
+# pipeline_options:
+# categories:
+# - IO
Review comment:
```suggestion
# - IO
# - Combiners
```
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/game/GameStatsTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.examples.complete.game;
+// beam-playground:
+// name: GameStatsTest
+// description: Unit-test for the GameStats example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Testing
Review comment:
```suggestion
// - Testing
// - Filtering
```
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/kafkatopubsub/KafkaToPubsubTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.examples.complete.kafkatopubsub;
+// beam-playground:
+// name: KafkaToPubsubTest
+// description: Unit-test for the KafkaToPubsub example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Streaming
+
Review comment:
Let's remove this file, it doesn't test anything related to Beam
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/cookbook/DistinctExampleTest.java
##########
@@ -17,6 +17,15 @@
*/
package org.apache.beam.examples.cookbook;
+// beam-playground:
+// name: DistinctExampleTest
+// description: Unit-test for the DistinctExample example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - IO
+// - Options
Review comment:
```suggestion
// - Core Transforms
// - Filtering
```
##########
File path: sdks/go/test/integration/integration.go
##########
@@ -34,6 +34,16 @@
// environment setup, or by calling gradle commands in :sdks:go:test.
package integration
+// beam-playground:
+// name: CheckFiltersTest
+// description: Unit-test checks if an integration test is filtered to be
skipped, either
+// because the intended runner does not support it, or the test is
sickbayed.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Filtering
+// - Testing
+
Review comment:
Let's remove this file, it doesn't test anything related to Beam
##########
File path: sdks/go/pkg/beam/transforms/filter/distinct_test.go
##########
@@ -15,6 +15,14 @@
package filter_test
+// beam-playground:
+// name: DistinctTest
+// description: Unit-test for the Distinct example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Filtering
Review comment:
```suggestion
// - Filtering
// - Core Transforms
```
##########
File path: sdks/go/test/integration/synthetic/synthetic_test.go
##########
@@ -15,6 +15,14 @@
package synthetic
+// beam-playground:
+// name: SyntheticTest
+// description: Unit-test for the Synthetic example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Testing
+
Review comment:
Seems like this test is something internal, let's remove it. It might be
not so interesting for Playground users
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileBasedSourceTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.sdk.io;
+// beam-playground:
+// name: FileBasedSourceTest
+// description: Unit-test for the FileBasedSource example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - IO
+
Review comment:
Let's remove this file, it tests Beam internals
##########
File path: sdks/go/pkg/beam/core/util/symtab/symtab_test.go
##########
@@ -15,6 +15,14 @@
package symtab
+// beam-playground:
+// name: SymtabTest
+// description: Unit-test for the Symtab example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Side Input
+
Review comment:
Let's remove this file, it doesn't test anything related to Beam
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/ConvertTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.sdk.schemas.transforms;
+// beam-playground:
+// name: ConvertTest
+// description: Unit-test for the Convert example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Schemas
+
Review comment:
Let's remove this file, it tests Beam internals
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/testing/TestStreamTest.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.beam.sdk.testing;
+// beam-playground:
+// name: TestStreamTest
+// description: Unit-test for the TestStream example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Testing
Review comment:
```suggestion
// - Streaming
```
##########
File path: sdks/python/apache_beam/io/filesystemio_test.py
##########
@@ -19,6 +19,14 @@
# pytype: skip-file
+# beam-playground:
+# name: FileSystemIOTest
+# description: Unit-test for the FileSystemIO example.
+# multifile: false
+# pipeline_options:
+# categories:
+# - IO
+
Review comment:
Let's remove this file, it tests Beam internals
##########
File path: sdks/python/apache_beam/examples/wordcount_test.py
##########
@@ -20,6 +20,14 @@
# pytype: skip-file
+# beam-playground:
+# name: WordCountTest
+# description: Unit-test for the WordCount example.
+# multifile: false
+# pipeline_options:
+# categories:
+# - IO
Review comment:
```suggestion
# - IO
# - Combiners
```
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowingTest.java
##########
@@ -17,6 +17,15 @@
*/
package org.apache.beam.sdk.transforms.windowing;
+// beam-playground:
+// name: WindowingTest
+// description: Unit-test for the Windowing kata.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Windowing
+// - Streaming
+
Review comment:
Let's remove this file, it tests Beam internals
##########
File path: sdks/python/apache_beam/transforms/window_test.py
##########
@@ -18,6 +18,15 @@
"""Unit tests for the windowing classes."""
# pytype: skip-file
+# beam-playground:
+# name: MetricTest
+# description: Unit-test for the Window example.
+# multifile: false
+# pipeline_options:
+# categories:
+# - Core Transforms
+# - Windowing
+
Review comment:
Let's remove this file, it tests Beam internals
##########
File path: sdks/go/test/integration/xlang/xlang_test.go
##########
@@ -15,6 +15,15 @@
package xlang
+// beam-playground:
+// name: XLangTest
+// description: Unit-test for the XLang example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - Combiners
+// - Testing
Review comment:
Let's remove this file as well, it's hard to understand and it also
seems like not related to Playground users
##########
File path: sdks/python/apache_beam/examples/streaming_wordcount_it_test.py
##########
@@ -19,6 +19,14 @@
# pytype: skip-file
+# beam-playground:
+# name: StreamingWordCountITTest
+# description: Unit-test for the streaming WordCount example.
+# multifile: false
+# pipeline_options:
+# categories:
+# - Streaming
Review comment:
```suggestion
# - Streaming
# - IO
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 701504)
Time Spent: 8h 10m (was: 8h)
> Tag existing unit-tests
> -----------------------
>
> Key: BEAM-13471
> URL: https://issues.apache.org/jira/browse/BEAM-13471
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Pavel Avilov
> Assignee: Pavel Avilov
> Priority: P2
> Labels: beam-playground-backend, beam-playground-sprint-5
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Need to add a beam playground tag for the existing unit tests.
> Tag ~10 useful and representative unit tests per SDK
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
