[ 
https://issues.apache.org/jira/browse/BEAM-13559?focusedWorklogId=701335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-701335
 ]

ASF GitHub Bot logged work on BEAM-13559:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Dec/21 15:17
            Start Date: 27/Dec/21 15:17
    Worklog Time Spent: 10m 
      Work Description: KhaninArtur commented on a change in pull request 
#16365:
URL: https://github.com/apache/beam/pull/16365#discussion_r775542448



##########
File path: playground/infrastructure/test_helper.py
##########
@@ -135,15 +135,15 @@ def test__check_file_with_correct_tag(
   assert len(examples) == 1
   assert examples[0] == example
   mock_get_tag.assert_called_once_with("/root/filename.java")
-  mock_validate.assert_called_once_with(tag, [])
+  mock_validate.assert_called_once_with(tag.tag_as_dict, [])

Review comment:
       Can we add a test case(-s) to check that the collected `tag_string` is 
correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 701335)
    Time Spent: 0.5h  (was: 20m)

> [Playground] Remove tag in examples CD
> --------------------------------------
>
>                 Key: BEAM-13559
>                 URL: https://issues.apache.org/jira/browse/BEAM-13559
>             Project: Beam
>          Issue Type: Task
>          Components: beam-playground
>            Reporter: Artur Khanin
>            Assignee: Aydar Zaynutdinov
>            Priority: P2
>              Labels: beam-playground-backend, beam-playground-sprint-6
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In examples CD tag must be removed for precompiled objects.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to