[
https://issues.apache.org/jira/browse/BEAM-13334?focusedWorklogId=690143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690143
]
ASF GitHub Bot logged work on BEAM-13334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/21 16:23
Start Date: 03/Dec/21 16:23
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on a change in pull request
#16121:
URL: https://github.com/apache/beam/pull/16121#discussion_r762074820
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -250,6 +308,55 @@ func cancelCheck(ctx context.Context, pipelineId
uuid.UUID, cancelChannel chan b
}
}
+// readLogFile reads logs from the log file and keeps it to the cache.
+// If context is done it means that the code processing was finished
(successfully/with error/timeout). Write last logs to the cache.
+// If <-stopReadLogsChannel it means that the code processing was finished
(canceled/timeout)
+// and it waits until the method stops the work to change status to the
pb.Status_STATUS_FINISHED. Write last logs
Review comment:
It is not necessary. Just wanted to separate it from other `If` cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 690143)
Time Spent: 2h (was: 1h 50m)
> [Playground] Save Go logs to the cache
> --------------------------------------
>
> Key: BEAM-13334
> URL: https://issues.apache.org/jira/browse/BEAM-13334
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Zaynutdinov
> Assignee: Aydar Zaynutdinov
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-5
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Configure Go code processing to save all code processing logs to the cache
> using a certain `pipelineId` as a key and a new subKey `Logs`.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
