[
https://issues.apache.org/jira/browse/BEAM-13210?focusedWorklogId=681586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681586
]
ASF GitHub Bot logged work on BEAM-13210:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/21 16:00
Start Date: 15/Nov/21 16:00
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#15956:
URL: https://github.com/apache/beam/pull/15956#discussion_r749463537
##########
File path: playground/frontend/lib/constants/api.dart
##########
@@ -16,4 +16,5 @@
* limitations under the License.
*/
-const String kApiClientURL = 'https://datatokenization.uc.r.appspot.com';
+const String kApiClientURL =
+ 'https://backend-dot-datatokenization.uc.r.appspot.com';
Review comment:
May we consider not hardcoding the URL in the codebase? Apologies that
I missed it in an earlier review. One possible way to solve it is using a
`config.json` file like
[this](https://github.com/damondouglas/fs-auth-example/tree/main/frontend/assets#configjson)
and
[this](https://github.com/damondouglas/fs-auth-example/blob/main/frontend/lib/config.dart).
The friction, however, is that it requires creating and maintaining this
file. Perhaps we can add a gradle task that creates this config, acquiring the
endpoint URL from a gradle.properties file in
`playground/frontend/gradle.properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 681586)
Time Spent: 0.5h (was: 20m)
> [Playground] support streaming output on the frontend
> -----------------------------------------------------
>
> Key: BEAM-13210
> URL: https://issues.apache.org/jira/browse/BEAM-13210
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Farrakhov
> Assignee: Aydar Farrakhov
> Priority: P3
> Labels: beam-playground-frontend, beam-playground-sprint-3
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Update Run Pipeline requests to get output log from the server before
> pipeline is finished
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
