[
https://issues.apache.org/jira/browse/BEAM-6703?focusedWorklogId=214736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214736
]
ASF GitHub Bot logged work on BEAM-6703:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 12:38
Start Date: 18/Mar/19 12:38
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8053: [BEAM-6703]
Added a Jenkins job to test Dataflow portability API with Java 11
URL: https://github.com/apache/beam/pull/8053#discussion_r266418232
##########
File path:
.test-infra/jenkins/job_PostCommit_Java11_ValidatesRunner_PortabilityApi_Dataflow.groovy
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PhraseTriggeringPostCommitBuilder
+
+
+PhraseTriggeringPostCommitBuilder.postCommitJob('beam_PostCommit_Java11_ValidatesRunner_PortabilityApi_Dataflow',
+ 'Run Dataflow PortabilityApi ValidatesRunner with Java 11', 'Google Cloud
Dataflow Runner PortabilityApi ValidatesRunner Java 11 Tests', this) {
+
+ description('Runs the ValidatesRunner suite on the Java 11 enabled Dataflow
PortabilityApi runner.')
+
+ commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 180)
+
+ publishers {
+ archiveJunit('**/build/test-results/**/*.xml')
+ }
+
+ steps {
+ gradle {
+ rootBuildScriptDir(commonJobProperties.checkoutDir)
+
tasks(':beam-runners-google-cloud-dataflow-java:validatesRunnerFnApiWorkerTest')
+ switches ('-Pdockerfile=Dockerfile-java11')
+ commonJobProperties.setGradleSwitches(delegate, 3 *
Runtime.runtime.availableProcessors())
Review comment:
I think here it makes perfect sense to copy the comment from
`job_postCommit_java_ValidatesRunner_PortabilityApi_Dataflow.groovy` explaining
why do we multiply by 3. 3 without any explanation is a "magic number". For the
sake of this pr a comment will be enough imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 214736)
Time Spent: 12h 50m (was: 12h 40m)
> Support Java 11 in Jenkins
> --------------------------
>
> Key: BEAM-6703
> URL: https://issues.apache.org/jira/browse/BEAM-6703
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow, runner-direct
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> In this issue I'll create a Jenkins job that compiles Dataflow and Direct
> runners with tests using Java 8 and runs Validates Runner suites with Java 11
> Runtime.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
