[
https://issues.apache.org/jira/browse/BEAM-11868?focusedWorklogId=560231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560231
]
ASF GitHub Bot logged work on BEAM-11868:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/21 00:49
Start Date: 03/Mar/21 00:49
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #14060:
URL: https://github.com/apache/beam/pull/14060#discussion_r586020750
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -369,6 +370,53 @@ def has_ontime_pane(self):
return False
+class AfterSynchronizedProcessingTime(TriggerFn):
Review comment:
Given you're already doing a local import, I would be fine with
importing it directly from here rather than putting it in `__all__`. (That and
we could add a leading underscore.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 560231)
Time Spent: 1h 10m (was: 1h)
> Python AfterProcessingTime triggers result in additional delay at each GBK
> --------------------------------------------------------------------------
>
> Key: BEAM-11868
> URL: https://issues.apache.org/jira/browse/BEAM-11868
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> See thread discussing it:
> https://lists.apache.org/thread.html/rd1b59fead3927b8769514f65fa66c051f80f68a6115dae356e86302c%40%3Cdev.beam.apache.org%3E
> The solution is to switch to match Java and have
> "AfterSynchronizedProcessingTime" but also to allow a runner to ignore that
> trigger and do whatever it wants.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
