[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=538001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538001
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 19:06
Start Date: 19/Jan/21 19:06
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #13656:
URL: https://github.com/apache/beam/pull/13656#discussion_r560416204
##########
File path: runners/direct-java/build.gradle
##########
@@ -72,17 +73,12 @@ dependencies {
shadow library.java.vendored_grpc_1_26_0
shadow library.java.joda_time
shadow library.java.slf4j_api
- shadow library.java.args4j
+ compile library.java.jackson_databind
Review comment:
Is a `compile` time dependency required here, or can this be shadowed?
##########
File path: runners/direct-java/build.gradle
##########
@@ -93,6 +89,10 @@ dependencies {
validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
validatesRunner project(path: project.path, configuration: "shadow")
validatesRunner project(path: project.path, configuration: "shadowTest")
+ //runtime dependencies of the tests
+ permitUnusedDeclared library.java.vendored_grpc_1_26_0
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
This seems like a heavyweight approach. Could you elaborate on why these
are permitted? Perhaps providing some evidence of the failures would help
determine a more nuanced approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538001)
Time Spent: 56h (was: 55h 50m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 56h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
