[
https://issues.apache.org/jira/browse/BEAM-10941?focusedWorklogId=487352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487352
]
ASF GitHub Bot logged work on BEAM-10941:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 00:29
Start Date: 22/Sep/20 00:29
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12900:
URL: https://github.com/apache/beam/pull/12900#issuecomment-696448479
# [Codecov](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=h1) Report
> Merging
[#12900](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/067cba8229694e7fb9693313f51ca686746b620a?el=desc)
will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12900 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 452 452
Lines 54016 54018 +2
=======================================
+ Hits 44481 44483 +2
Misses 9535 9535
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/12900/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5)
| `95.84% <100.00%> (+1.77%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/12900/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5)
| `90.90% <0.00%> (-0.76%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12900/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `88.75% <0.00%> (-0.45%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12900/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `94.45% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=footer). Last
update
[067cba8...e29eaad](https://codecov.io/gh/apache/beam/pull/12900?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 487352)
Time Spent: 0.5h (was: 20m)
> Use standard sharding conventions for fileio writes.
> ----------------------------------------------------
>
> Key: BEAM-10941
> URL: https://issues.apache.org/jira/browse/BEAM-10941
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Priority: P2
> Fix For: 2.25.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, it names shards sssss-nnnnn rather than sssss-of-nnnnn. There are
> also extra dashes placed in the filepath for panes and the global window,
> yielding names like "base---00000-of-00001"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
