[
https://issues.apache.org/jira/browse/BEAM-5715?focusedWorklogId=473526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473526
]
ASF GitHub Bot logged work on BEAM-5715:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/20 04:45
Start Date: 22/Aug/20 04:45
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #12669:
URL: https://github.com/apache/beam/pull/12669#issuecomment-678593835
R: @tvalentyn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473526)
Time Spent: 0.5h (was: 20m)
> Depending on grpc-all pulls in more dependencies than necessary
> ---------------------------------------------------------------
>
> Key: BEAM-5715
> URL: https://issues.apache.org/jira/browse/BEAM-5715
> Project: Beam
> Issue Type: Improvement
> Components: dependencies
> Reporter: Hongxin Liang
> Priority: P3
> Fix For: 2.25.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> h3. Description:
> grpc-all introduces both grpc-netty and grpc-okhttp. According to
> [https://github.com/grpc/grpc-java/pull/1924], this is not recommended.
> grpc-okhttp is better for Android.
> Beam depends on both
> [grpc-all|https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L389]
> and
> [grpc-netty|https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L395]
> explicitly. Not sure this is to keep transitive dependencies backward
> compatible or other reasons.
> h3. Desired state:
> Beam does not depend on grpc-all, and only depends on necessary parts of grpc
> explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
