[ 
https://issues.apache.org/jira/browse/BEAM-9919?focusedWorklogId=466942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466942
 ]

ASF GitHub Bot logged work on BEAM-9919:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Aug/20 18:53
            Start Date: 05/Aug/20 18:53
    Worklog Time Spent: 10m 
      Work Description: pskevin commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r465934906



##########
File path: sdks/go/pkg/beam/external.go
##########
@@ -16,10 +16,144 @@
 package beam
 
 import (
+       "context"
+       "fmt"
+
        "github.com/apache/beam/sdks/go/pkg/beam/core/graph"
+       "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/graphx"
        "github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
+       jobpb "github.com/apache/beam/sdks/go/pkg/beam/model/jobmanagement_v1"
+       pipepb "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
+       "google.golang.org/grpc"
 )
 
+// ExternalTransform represents the cross-language transform in and out of the 
Pipeline as a MultiEdge and Expanded proto respectively
+type ExternalTransform struct {
+       id                int
+       Urn               string
+       Payload           []byte
+       In                []PCollection
+       Out               []FullType
+       Bounded           bool
+       ExpansionAddr     string
+       Components        *pipepb.Components
+       ExpandedTransform *pipepb.PTransform
+       Requirements      []string

Review comment:
       Awesome suggestion. Will work on it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 466942)
    Time Spent: 4h 50m  (was: 4h 40m)

> Add an External transform API to Go SDK
> ---------------------------------------
>
>                 Key: BEAM-9919
>                 URL: https://issues.apache.org/jira/browse/BEAM-9919
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Chamikara Madhusanka Jayalath
>            Priority: P3
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> This transform will be able to expand cross-language transforms by connecting 
> to a remote expansion service through Beam expansion API.
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_expansion_api.proto]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to