[
https://issues.apache.org/jira/browse/BEAM-10289?focusedWorklogId=465272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465272
]
ASF GitHub Bot logged work on BEAM-10289:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/20 04:21
Start Date: 01/Aug/20 04:21
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #12350:
URL: https://github.com/apache/beam/pull/12350#issuecomment-667466351
Added a new commit addressing the latest comments, and also adding a timeout
to the usage of the SplittableUnit channel in DataSource, to avoid the
possibility of it blocking for arbitrarily long periods of time.
The timeout I chose was arbitrary, and the idea of choosing a timeout in the
first place instead of just a default case is to avoid the subtle edge case
where a split occurs right after the current element has incremented in
DataSource, but before that element has begun processing in the splittable
unit. Without the timeout, those cases will result in avoiding a sub-element
split when one was possible if we just waited slightly longer. But maybe I'm
just overthinking it, and that case is rare enough that it's not worth worrying
about. I'm still pretty undecided on it, and I'd like to hear your opinion
@lostluck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 465272)
Time Spent: 2h 20m (was: 2h 10m)
> Implement dynamic splitting support for SDFs in Go SDK.
> -------------------------------------------------------
>
> Key: BEAM-10289
> URL: https://issues.apache.org/jira/browse/BEAM-10289
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
