[
https://issues.apache.org/jira/browse/BEAM-10546?focusedWorklogId=461820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461820
]
ASF GitHub Bot logged work on BEAM-10546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/20 01:33
Start Date: 22/Jul/20 01:33
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #12332:
URL: https://github.com/apache/beam/pull/12332#discussion_r458481764
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
##########
@@ -155,7 +154,6 @@ def process(self, element):
@unittest.skipIf(
sys.version_info < (3, 5, 3),
'The tests require at least Python 3.6 to work.')
- @timeout(60)
Review comment:
Do you want to replace the decorators with `@pytest.mark.timeout(60)`,
etc.?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461820)
Time Spent: 0.5h (was: 20m)
> Remove util.timeout
> -------------------
>
> Key: BEAM-10546
> URL: https://issues.apache.org/jira/browse/BEAM-10546
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P3
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> util.timeout is obsolete since the resolution of BEAM-9009. Its remaining in
> the codebase is even misleading because it does not override the default
> pytest timeout (600s), so util.timeout only has an effect when it is set
> shorter than 600s. It only has a few usages and these can be removed.
> https://github.com/apache/beam/blob/6c68bc6c4f44b49c02f966f655e654235d04b365/sdks/python/apache_beam/testing/util.py#L343
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
