Justin Bertram created ARTEMIS-5902:
---------------------------------------
Summary: Optimize authentication cache key creation
Key: ARTEMIS-5902
URL: https://issues.apache.org/jira/browse/ARTEMIS-5902
Project: Artemis
Issue Type: Improvement
Reporter: Justin Bertram
Assignee: Justin Bertram
Currently the process to create an authentication cache key involves _always_
invoking {{java.security.MessageDigest#getInstance(java.lang.String)}}. This
isn't strictly necessary. We can use a pattern similar to
{{org.apache.activemq.artemis.protocol.amqp.sasl.scram.ScramServerFunctionalityImpl}}
which uses {{clone()}} on the {{MessageDigest}} to avoid invoking
{{getInstance}} every time.
Also, we can hash fewer bytes and avoid unnecessary String concatenations by
inspecting each part of the input and only adding bytes that actually make a
difference to the final hash.
These are relatively minor improvements, but are simple and still worth doing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
