tabish121 commented on code in PR #6218:
URL: https://github.com/apache/artemis/pull/6218#discussion_r2761045252
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageWriter.java:
##########
@@ -173,6 +173,11 @@ private void tryDelivering() {
logger.trace("AMQP Large Message Writer was closed before queued
write attempt was executed");
return;
}
+ if (protonSender.getSession().getConnection().getRemoteState() !=
EndpointState.ACTIVE ||
protonSender.getSession().getConnection().getLocalState() !=
EndpointState.ACTIVE) {
Review Comment:
The code actually already has several checks for closed state related to the
sender but in reality even this is not a guarantee that you won't see this
error as the proton code was not meant to be used outside the thread that
manages the engine so the visibility of these values is not ensured to be
updated in this delivering thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
