gtully commented on code in PR #6202:
URL: https://github.com/apache/artemis/pull/6202#discussion_r2747172535
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java:
##########
@@ -865,10 +865,10 @@ public synchronized void pause() {
// We *pause* the acceptor so no new connections are made
if (serverChannelGroup != null) {
if (!serverChannelGroup.close().awaitUninterruptibly(shutdownTimeout,
TimeUnit.MILLISECONDS)) {
Review Comment:
I think we should only wait for the close in the presence of a
shutdownTimeout > 0, in that way we won't warn unless the caller cares about
the outcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
